RFR: 8317349: Randomize order of macro node expansion in C2 [v3]

[Christian Hagedorn]

On Tue, 6 Feb 2024 11:06:25 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Sure, that sounds good. Maybe we should just have a single phase `PHASE_AFTER_MACRO_EXPANSION_STEP` to keep things simple? Even for the Opaque and LoopLimit node eliminations (as they are structurally part of the `expand_macro_nodes` function). We can refactor and move that eliminiation outside `expand_macro_nodes` in the RFE.
>> 
>> In summary, we then only have the phases:
>> 
>>   flags(BEFORE_MACRO_EXPANSION ,         "Before Macro Expansion") \
>>   flags(AFTER_MACRO_EXPANSION_STEP, "After Macro Expansion Step") \
>>   flags(AFTER_MACRO_EXPANSION,           "After Macro Expansion") \
>
>> Sure, that sounds good. Maybe we should just have a single phase `PHASE_AFTER_MACRO_EXPANSION_STEP` to keep things simple? Even for the Opaque and LoopLimit node eliminations (as they are structurally part of the `expand_macro_nodes` function). We can refactor and move that eliminiation outside `expand_macro_nodes` in the RFE.
>> 
>> In summary, we then only have the phases:
>> 
>> ```
>>   flags(BEFORE_MACRO_EXPANSION ,         "Before Macro Expansion") \
>>   flags(AFTER_MACRO_EXPANSION_STEP, "After Macro Expansion Step") \
>>   flags(AFTER_MACRO_EXPANSION,           "After Macro Expansion") \
>> ```
> 
> Sounds good to me.

Good idea, let's go with that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17684#discussion_r1479621016