RFR: 8317349: Randomize order of macro node expansion in C2 [v3]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Feb 6 11:08:56 UTC 2024


On Tue, 6 Feb 2024 11:01:43 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

> Sure, that sounds good. Maybe we should just have a single phase `PHASE_AFTER_MACRO_EXPANSION_STEP` to keep things simple? Even for the Opaque and LoopLimit node eliminations (as they are structurally part of the `expand_macro_nodes` function). We can refactor and move that eliminiation outside `expand_macro_nodes` in the RFE.
> 
> In summary, we then only have the phases:
> 
> ```
>   flags(BEFORE_MACRO_EXPANSION ,         "Before Macro Expansion") \
>   flags(AFTER_MACRO_EXPANSION_STEP, "After Macro Expansion Step") \
>   flags(AFTER_MACRO_EXPANSION,           "After Macro Expansion") \
> ```

Sounds good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17684#discussion_r1479594088


More information about the hotspot-compiler-dev mailing list