RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v6]

[Emanuel Peter]

On Thu, 8 Feb 2024 10:22:08 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> OK thanks I think I misread. I now have some correctness tests for tests with and without reassociation. 
>> 
>> We can't add correctness tests for tests with random inputs because we do not know how many iterations there will be. There are two tests with reassociation `equalsVariantSubInvarint(Int|Long)` that have a drastically different graph with the correctness change that messes up the IR matching, so I opted out of changes those as well.
>
>> We can't add correctness tests for tests with random inputs because we do not know how many iterations there will be.
> 
> You could wait a few days for this to be integrated ;)
> https://github.com/openjdk/jdk/pull/17557

In fact, that would probably be smart. Otherwise you only have result verification for constant values. And who knows, there the code might constant-fold in a way that we don't expect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17375#discussion_r1482736567