RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v6]
Joshua Cao
duke at openjdk.org
Thu Feb 8 17:09:06 UTC 2024
On Thu, 8 Feb 2024 10:24:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>>> We can't add correctness tests for tests with random inputs because we do not know how many iterations there will be.
>>
>> You could wait a few days for this to be integrated ;)
>> https://github.com/openjdk/jdk/pull/17557
>
> In fact, that would probably be smart. Otherwise you only have result verification for constant values. And who knows, there the code might constant-fold in a way that we don't expect.
I am with you that I am not 100% happy with the tests. I do not mind waiting for that PR to get integrated.
If I understand correctly, that PR is more for convenience of setting up arguments. How will that help testing correctness for random inputs?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17375#discussion_r1483315089
More information about the hotspot-compiler-dev
mailing list