RFR: 8325541: C2 SuperWord: refactor filter / split [v2]

Emanuel Peter epeter at openjdk.org
Fri Feb 9 15:41:09 UTC 2024


On Fri, 9 Feb 2024 15:24:07 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/superword.cpp line 1885:
>> 
>>> 1883:   while (true) {
>>> 1884:     int old_packset_length = _packset.length();
>>> 1885:     filter_packs(nullptr, // don't dump each time
>> 
>> Is it too verbose?
>
> Yes. And it does not make sense to print the packset and the filter_name for every round. That is why I have the printing at the end of all rounds below.

During every round, we may remove some packs. And then they are printed with `SW_REJECTIONS`. If I now also print the packset every round, it gets difficult to read.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17785#discussion_r1484487422


More information about the hotspot-compiler-dev mailing list