RFR: 8325541: C2 SuperWord: refactor filter / split [v5]

Christian Hagedorn chagedorn at openjdk.org
Mon Feb 12 08:49:00 UTC 2024


On Fri, 9 Feb 2024 15:16:42 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/superword.cpp line 587:
>> 
>>> 585:   filter_packs_for_alignment();
>>> 586:   filter_packs_for_implemented();
>>> 587:   filter_packs_for_profitable();
>> 
>> How about keeping `filter_packs()` which then calls all 5 new `filter_packs*` methods?
>
> I want to keep them all there for now. I have some ideas about how to convert some of the filter methods to split methods. It is easier if everything is now a big laundry list, and we can group everything in a future RFE. Ok?

That's fine

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17785#discussion_r1485871204


More information about the hotspot-compiler-dev mailing list