RFR: 8324969: assert(false) failed: Non-balanced monitor enter/exit! [v4]

[Vladimir Kozlov]

On Tue, 13 Feb 2024 22:57:52 GMT, Dean Long <dlong at openjdk.org> wrote:

> Doesn't this end up marking even the simplest lock coarsening cases as unbalanced?

Yes, the simplest lock coarsening makes locking regions as unbalanced.
See second code example in PR's description. Coarsening eliminates Unlock in regions 1 and Lock in region 2. Both regions become unbalanced.

> Is there a reason the above check can't be done as part of coarsened_locks_consistent()?

`Unbalanced` in coarsened_locks_consistent() is different from `Unbalanced` in `mark_coarsened_boxes()`
Or do you mean to recompile without lock coarsening when regions are unbalanced? But that will disable all coarsening, even valid one (for example, when no outer locking in my examples).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17697#discussion_r1488736908