RFR: 8325746: Refactor Loop Unswitching code

[Emanuel Peter]

On Wed, 14 Feb 2024 10:54:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/loopUnswitch.cpp line 359:
>> 
>>> 357:   IfNode* unswitch_candidate = unswitched_loop_selector.unswitch_candidate();
>>> 358:   IfNode* loop_selector = unswitched_loop_selector.selector();
>>> 359:   Node_List worklist;
>> 
>> Should there be a ResourceMark for this? There was none before either though.
>
> Suggestion:
> 
>   ResourceMark rm;
>   GrowableArray<CheckCastPPNode*> loop_invariant_check_casts;

We might as well improve the type of the nodes, and the name of the list.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17842#discussion_r1489287960