RFR: 8325746: Refactor Loop Unswitching code [v4]

Christian Hagedorn chagedorn at openjdk.org
Wed Feb 14 14:47:12 UTC 2024


On Wed, 14 Feb 2024 14:24:21 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change block -> path
>
> src/hotspot/share/opto/loopUnswitch.cpp line 70:
> 
>> 68: //    Endloop                                                   cloned if-path                    [cloned else-path]
>> 69: //                                                              cloned stmt2                      cloned stmt2
>> 70: //                                                            Endloop                           Endloop
> 
> Could it be the other way around: the if-path is empty and the else-path has code? Or are you just trying to suggest that there could be an empty path, and that this would really simplify one of the cloned loops now?

Yes, it would be a simplification. But as suggested in the other comment. It might create more confusion than actually helping.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17842#discussion_r1489587101


More information about the hotspot-compiler-dev mailing list