RFR: 8325589: C2 SuperWord refactoring: create VLoopAnalyzer with Submodules [v3]
Emanuel Peter
epeter at openjdk.org
Wed Feb 14 15:57:08 UTC 2024
On Wed, 14 Feb 2024 15:31:40 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>>
>> - manual merge
>> - move _loop_or_ctrl from ResouceArena, bc ResourceMark in SuperWord::dependence_graph
>> - remove some comments
>> - VLoopTypes
>> - VLoopBody
>> - VLoopMemorySlices
>> - VLoopReductions
>> - 8325589
>
> src/hotspot/share/opto/superword.hpp line 235:
>
>> 233: CountedLoopNode* cl() const { return vloop().cl(); }
>> 234: PhiNode* iv() const { return vloop().iv(); }
>> 235: int iv_stride() const { return cl()->stride_con(); }
>
> Could these also be field? You access these quite a lot but only inside this class and they seem to be constant.
I aready did this in a previous PR. If we think it is important to cache these values for performance, then we can do that in a future RFE.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17800#discussion_r1489705877
More information about the hotspot-compiler-dev
mailing list