RFR: 8325589: C2 SuperWord refactoring: create VLoopAnalyzer with Submodules [v3]

[Christian Hagedorn]

On Wed, 14 Feb 2024 15:54:07 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/superword.hpp line 235:
>> 
>>> 233:   CountedLoopNode* cl()                 const { return vloop().cl(); }
>>> 234:   PhiNode* iv()                         const { return vloop().iv(); }
>>> 235:   int iv_stride()                       const { return cl()->stride_con(); }
>> 
>> Could these also be field? You access these quite a lot but only inside this class and they seem to be constant.
>
> I aready did this in a previous PR. If we think it is important to cache these values for performance, then we can do that in a future RFE.

I don't think it matters for performance. I was more thinking that it's easier to have immutable fields over const methods - but I guess it's also a matter of taste.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17800#discussion_r1489720582