RFR: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop

[Vladimir Kozlov]

On Mon, 26 Feb 2024 12:59:16 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> I could do that but it would feel a bit arbitrary to put the assert only in this code, given that we have the same `is_Loop` check in a lot of other code as well. Maybe it would make sense to factor the checks into a separate method at some point.
>
> Makes sense to do a complete replacement of this pattern in other code as well at some point. But let's do that separately.

I agree with refactoring in separate RFE. 

Regarding these changes: should we simply skip this optimization if we see irreducible loop? They may have additional entry into the body so such transformation could be incorrect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18002#discussion_r1503053274