RFR: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop [v2]

[Tobias Hartmann]

On Mon, 26 Feb 2024 17:41:40 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Makes sense to do a complete replacement of this pattern in other code as well at some point. But let's do that separately.
>
> I agree with refactoring in separate RFE. 
> 
> Regarding these changes: should we simply skip this optimization if we see irreducible loop? They may have additional entry into the body so such transformation could be incorrect.

Right, let's better be safe than sorry and skip this optimization for irreducible loops. The other optimizations in that method look safe though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18002#discussion_r1503866055