RFR: 8322959: vectorapi: get wrong argument for `limit` in indexPartiallyInUpperRange intrinsic

Vladimir Kozlov kvn at openjdk.org
Wed Jan 3 18:00:39 UTC 2024


On Wed, 3 Jan 2024 17:10:07 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Hi,
>> Can you review this simple fix for indexPartiallyInUpperRange intrinsic?
>> Thanks.
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 3151:
> 
>> 3149: 
>> 3150:   Node* offset = argument(3);
>> 3151:   Node* limit = argument(4);
> 
> The offset is of long type so will take 2 spots (3 and 4) of argument. So limit will be argument(5).  The original code (limit = argument(5)) looks correct to me.

@sviswa7 is right. @Hamlin-Li you do you have a test case where the value is wrong?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17247#discussion_r1440743534


More information about the hotspot-compiler-dev mailing list