RFR: 8322959: vectorapi: get wrong argument for `limit` in indexPartiallyInUpperRange intrinsic

Hamlin Li mli at openjdk.org
Thu Jan 4 09:17:28 UTC 2024


On Wed, 3 Jan 2024 17:10:07 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Hi,
>> Can you review this simple fix for indexPartiallyInUpperRange intrinsic?
>> Thanks.
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 3151:
> 
>> 3149: 
>> 3150:   Node* offset = argument(3);
>> 3151:   Node* limit = argument(4);
> 
> The offset is of long type so will take 2 spots (3 and 4) of argument. So limit will be argument(5).  The original code (limit = argument(5)) looks correct to me.

@sviswa7 Oh, thanks for correct me, I did not realise this.

@vnkozlov I did run the tests `test/jdk/jdk/incubator/vector` and `test/hotspot/jtreg/compiler/vectorapi/` after applying the patch. I thought it's because this intrinsic is not covered yet, but seems I'm wrong.

I will close this pr and bug later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17247#discussion_r1441509274


More information about the hotspot-compiler-dev mailing list