RFR: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate [v2]

Tobias Hartmann thartmann at openjdk.org
Fri Jan 5 07:16:24 UTC 2024


On Thu, 4 Jan 2024 16:19:22 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> I'm not sure why the recommended adjustment is needed. The macro assembler does fuse pairs of adjacent ldr instructions into an ldp but only when the sizes match and the offsets fit into the requisite number of bits.
>> 
>> So, if the two ldr instrctions ar egenerated next to each other the macroasembler should only convert to ldp *where appropriate*. Am I missing something here?
>
> Doh, sorry - I misread Andrew's proposed code! Ignore the noise.

Thanks for looking at this @adinn. Right, the macro assembler merge magic is nice, I didn't know about it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17266#discussion_r1442560775


More information about the hotspot-compiler-dev mailing list