RFR: 8282365: Consolidate and improve division by constant idealizations [v42]

Quan Anh Mai qamai at openjdk.org
Sun Jan 7 15:52:20 UTC 2024


On Tue, 2 Jan 2024 09:23:37 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   power of 2
>
> test/hotspot/gtest/opto/test_constant_division.cpp line 29:
> 
>> 27: #include "runtime/os.hpp"
>> 28: #include "utilities/growableArray.hpp"
>> 29: #include <type_traits>
> 
> Move include.

I was told that `unittest.hpp` should come last so this is the order, I have added a line between JDK header and stdlib header as well as resolved your other comments. Thanks a lot.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1444028106


More information about the hotspot-compiler-dev mailing list