RFR: 8282365: Consolidate and improve division by constant idealizations [v42]

[Stefan Karlsson]

On Sun, 7 Jan 2024 15:44:44 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> test/hotspot/gtest/opto/test_constant_division.cpp line 29:
>> 
>>> 27: #include "runtime/os.hpp"
>>> 28: #include "utilities/growableArray.hpp"
>>> 29: #include <type_traits>
>> 
>> Move include.
>
> I was told that `unittest.hpp` should come last so this is the order, I have added a line between JDK header and stdlib header as well as resolved your other comments. Thanks a lot.

The rules around the includes lines in our tests and what we currently have in the tests are messy at the movement. We should fix that when we find the time to.

For HotSpot source code files the includes should be structured as::

hotspot includes
blank line
system includes


There are some deviations from that, but those should be cleaned up instead of used as a precedence. For our tests we should add "unittest.hpp" at the end of the "hotspot includes" section.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1444334222