RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v4]

Quan Anh Mai qamai at openjdk.org
Sun Jan 7 16:22:55 UTC 2024


> Hi,
> 
> This patch adds unsigned bounds and known bits constraints to `TypeInt` and `TypeLong`. This opens more transformation opportunities in an elegant manner as well as helps avoid some ad-hoc rules in Hotspot. The new constraints are applied to identity and value calls of the common nodes (Add, Sub, L/R/URShift, And, Or, Xor, bit counting, Cmp, Bool, ConvI2L/L2I), the detailed ideas for each node will be presented below.
> 
> In general, a `TypeInt/Long` represents a set of values `x` that satisfies: `x s>= lo && x s<= hi && x u>= ulo && x u<= uhi && (x & zeros) == 0 && (~x & ones) == 0`. These constraints are not independent, e.g. an int that lies in [0, 3] in signed domain must also lie in [0, 3] in unsigned domain and have all bits but the last 2 being unset. As a result, we must normalize the constraints (tighten the constraints so that they are optimal) before constructing a `TypeInt/Long` instance.
> 
> Please kindly review, thanks very much.
> 
> Testing
> 
> - [x] GHA
> - [x] Linux x64, tier 1-4

Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits:

 - Merge branch 'master' into improvevalue
 - improve add/sub implementation
 - Merge branch 'master' into improvevalue
 - typo
 - whitespace
 - fix tests for x86_32
 - fix widen of ConvI2L
 - problem lists
 - format
 - comment
 - ... and 16 more: https://git.openjdk.org/jdk/compare/faa9c690...de1bac2e

-------------

Changes: https://git.openjdk.org/jdk/pull/15440/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15440&range=03
  Stats: 3753 lines in 35 files changed: 1953 ins; 1234 del; 566 mod
  Patch: https://git.openjdk.org/jdk/pull/15440.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15440/head:pull/15440

PR: https://git.openjdk.org/jdk/pull/15440


More information about the hotspot-compiler-dev mailing list