RFR: 8322816: RISC-V: Incorrect guarantee in patch_vtype [v2]
Kim Barrett
kbarrett at openjdk.org
Mon Jan 8 01:05:40 UTC 2024
On Wed, 3 Jan 2024 01:59:00 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Rather than removing the guarantee, wouldn't it be better to guarantee/assert `vill == 0`?
>> Although looking at uses, that argument is a bool, so it should be `guarantee(!vill, ...)`.
>
> Hi, Yes, that's better. Maybe: `guarantee(!vill, "should be");`
I've changed the guarantee as discussed. There are further cleanups possible
here, but I'll leave that to the riscv port maintainers.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17215#discussion_r1444109348
More information about the hotspot-compiler-dev
mailing list