RFR: 8322816: RISC-V: Incorrect guarantee in patch_vtype [v2]
Fei Yang
fyang at openjdk.org
Mon Jan 8 02:08:22 UTC 2024
On Mon, 8 Jan 2024 01:05:39 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Please review this change that fixes a test for a guarantee. This also
>> removes a -Wparentheses warning when those are enabled (which is how the
>> problem was discovered).
>>
>> The problem is that operator precedence groups the sub-expressions differently
>> than intended. The fix is to override the operator precedence by adding
>> parentheses to achieve the intended grouping.
>>
>> Testing: Local (linux-x64) cross-build for linux-riscv with this change plus
>> -Wparentheses enabled and other changes to allow that to work.
>>
>> Requesting someone from the riscv porters to properly test this.
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>
> guarantee !vill
Marked as reviewed by fyang (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/17215#pullrequestreview-1807946542
More information about the hotspot-compiler-dev
mailing list