RFR: 8323115: x86-32: Incorrect predicates for cmov instruct transforms with UseSSE

Kim Barrett kbarrett at openjdk.org
Mon Jan 8 08:00:39 UTC 2024


Please review this change that fixes generation of CMOV by C2 as controlled by
UseSSE.  The predicates controlling that generation were using implicit
operator precedence that didn't have the expected grouping.  Fixed by adding
parentheses to make the desired grouping explicit.

Testing: Ran GHA with -Wparentheses enabled along with this and other changes
needed to make that work.

-------------

Commit messages:
 - fix predicates for cmov with UseSSE

Changes: https://git.openjdk.org/jdk/pull/17296/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17296&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8323115
  Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/17296.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17296/head:pull/17296

PR: https://git.openjdk.org/jdk/pull/17296


More information about the hotspot-compiler-dev mailing list