RFR: 8322759: Eliminate -Wparentheses warnings in compiler code [v2]

Aleksey Shipilev shade at openjdk.org
Mon Jan 8 11:50:22 UTC 2024


On Mon, 8 Jan 2024 05:37:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to eliminate some -Wparentheses warnings. This
>> involved simply adding a few parentheses to make some implicit operator
>> precedence explicit.
>> 
>> This change addresses non-C2 parts of the compiler component.
>> 
>> Testing: mach5 tier1
>> 
>> Also ran mach5 tier1 with these changes in conjunction enabling -Wparentheses
>> and other changes needed to make that work.
>
> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into compiler-wparentheses
>  - simplify asserts
>  - update copyrights for new year
>  - fix -Wparentheses warnings in non-C2 compiler code

Looks reasonable, thanks!

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17200#pullrequestreview-1808919758


More information about the hotspot-compiler-dev mailing list