RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v59]

[Emanuel Peter]

On Mon, 8 Jan 2024 14:48:01 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/superword.cpp line 1620:
>> 
>>> 1618: 
>>> 1619:   const MemNode* mem_ref = pack->at(0)->as_Mem();
>>> 1620:   VPointer mem_ref_p(mem_ref, phase(), lpt(), nullptr, false);
>> 
>> Since you renamed `p` -> `pack`, you should also rename this one to pack:
>> Suggestion:
>> 
>>   VPointer mem_ref_pack(mem_ref, phase(), lpt(), nullptr, false);
>
> I keep it without your suggestion.

The idea is that it is the pointer of the mem_ref

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1444769346