RFR: 8319850: PrintInlining should print which methods are late inlines [v2]

[Roland Westrelin]

On Thu, 7 Dec 2023 22:51:50 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> I'm not 100% sure if this covers all case of late inlines.
>> 
>> Passes jtreg tier1 locally on my Linux machine with a fastdebug build. With sample Java programs and -XX:+PrintInlining, I can see
>> 
>> 
>> @ 15   java.lang.Float::valueOf (9 bytes)   late inline (boxing method)
>
> Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - 8319850: PrintInlining should report late inlines
>  - Revert "8319850: PrintInlining should report late inlines"
>    
>    This reverts commit c5bfb832ff989261b6b2c98f26017c6491fe3067.
>  - 8319850: PrintInlining should report late inlines

When `InlineTree::ok_to_inline()` is called, some diagnostic message is recorded for the call site. Do I understand right that with this patch, if the call is inlined late, then that message is dropped and replaced by a new "late inline.." message? If that's the case, isn't it the case that sometimes the `InlineTree::ok_to_inline()` has some useful information that's lost when late inlining happens?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16595#issuecomment-1881167177