RFR: 8319850: PrintInlining should print which methods are late inlines [v2]
Joshua Cao
duke at openjdk.org
Thu Jan 11 19:17:24 UTC 2024
On Mon, 8 Jan 2024 14:55:19 GMT, Roland Westrelin <roland at openjdk.org> wrote:
> When `InlineTree::ok_to_inline()` is called, some diagnostic message is recorded for the call site. Do I understand right that with this patch, if the call is inlined late, then that message is dropped and replaced by a new "late inline.." message? If that's the case, isn't it the case that sometimes the `InlineTree::ok_to_inline()` has some useful information that's lost when late inlining happens?
Yeah I think you're right. It should not matter for the string/methodhandle/vector/boxing late inlines. But we can lose information for generic late inlines, for example a hot method that could not get inlined earlier due to lack of budget. I'll look into it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16595#issuecomment-1887800021
More information about the hotspot-compiler-dev
mailing list