Integrated: 8320128: Clean up Parse constructor for OSR
Xin Liu
xliu at openjdk.org
Mon Jan 8 18:56:34 UTC 2024
On Wed, 15 Nov 2023 07:01:35 GMT, Xin Liu <xliu at openjdk.org> wrote:
> There's a special case for the constructor of Parse. If current compilation is OSR and it is handling the top-level method(depth() == 1), then
>
> 1. _tf = C->tf();
> 2. _entry_bci = C->entry_bci();
> 3. _flow = method()->get_osr_flow_analysis(_entry_bci);
>
> We don't need to assign those member data twice. We can also factor out _flow->failing() for the special case and normal cases.
>
> It's worth mentioning that we can't save ciTypeFlow computation because
> get_osr_flow_analysis(_entry_bci) actually needs get_flow_analysis(method()).
This pull request has now been integrated.
Changeset: d47393bd
Author: Xin Liu <xliu at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/d47393bd8225e818f0f9cd45192a5e656018af11
Stats: 45 lines in 2 files changed: 19 ins; 17 del; 9 mod
8320128: Clean up Parse constructor for OSR
Reviewed-by: thartmann, shade
-------------
PR: https://git.openjdk.org/jdk/pull/16669
More information about the hotspot-compiler-dev
mailing list