RFR: 8322982: CTW fails to build after 8308753 [v2]

[Aleksey Shipilev]

On Mon, 8 Jan 2024 18:53:38 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> This patch fixes the build error of CTW by sidelining ModuleInfoWriter.java. ModuleInfoWriter uses Class-File API, which has transitioned to preview.
>> If we really need to compile it, we have to append --enable-preview and --source N. 
>> 
>> The fact is CTW itself doesn't depend on ModuleInfoWriter. I think it's easier to maintain CTW if we filter it out in Makefile.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Combine two functions into one.

Looks fine to me.

Marked as reviewed by shade (Reviewer).

test/hotspot/jtreg/testlibrary/ctw/Makefile line 45:

> 43: 
> 44: SRC_FILES = $(shell find $(SRC_DIR) -name '*.java')
> 45: # Exclude ModuleInfoWriter.java to circumvent '--enable-preview'.

Wording: `Exclude files that need --enable-preview to compile`. There would probably be more files later.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17292#pullrequestreview-1809880221
PR Review: https://git.openjdk.org/jdk/pull/17292#pullrequestreview-1809881199
PR Review Comment: https://git.openjdk.org/jdk/pull/17292#discussion_r1445230097