RFR: 8322982: CTW fails to build after 8308753 [v2]

Xin Liu xliu at openjdk.org
Mon Jan 8 20:08:40 UTC 2024


On Mon, 8 Jan 2024 19:25:54 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Combine two functions into one.
>
> test/hotspot/jtreg/testlibrary/ctw/Makefile line 45:
> 
>> 43: 
>> 44: SRC_FILES = $(shell find $(SRC_DIR) -name '*.java')
>> 45: # Exclude ModuleInfoWriter.java to circumvent '--enable-preview'.
> 
> Wording: `Exclude files that need --enable-preview to compile`. There would probably be more files later.

I took a look at LIB_FILES. Only 'ModuleInfoWriter.java' depends on advanced APIs. 
It was added to testlibrary in [JDK-8304163](https://bugs.openjdk.org/browse/JDK-8304163).

Yes, we may need to exclude more files in the future. Currently, Makefile selects LIB_FILES using wildcard matching. If it's necessary, we need to define LIB_FILES explicitly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17292#discussion_r1445271062


More information about the hotspot-compiler-dev mailing list