RFR: 8322816: RISC-V: Incorrect guarantee in patch_vtype [v3]
Kim Barrett
kbarrett at openjdk.org
Wed Jan 10 00:15:37 UTC 2024
> Please review this change that fixes a test for a guarantee. This also
> removes a -Wparentheses warning when those are enabled (which is how the
> problem was discovered).
>
> The problem is that operator precedence groups the sub-expressions differently
> than intended. The fix is to override the operator precedence by adding
> parentheses to achieve the intended grouping.
>
> Testing: Local (linux-x64) cross-build for linux-riscv with this change plus
> -Wparentheses enabled and other changes to allow that to work.
>
> Requesting someone from the riscv porters to properly test this.
Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into riscv-paren-bug
- guarantee !vill
- fix subexpression grouping in patch_vtype guarantee
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17215/files
- new: https://git.openjdk.org/jdk/pull/17215/files/ab335602..22fc7a2b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17215&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17215&range=01-02
Stats: 18102 lines in 593 files changed: 12845 ins; 2510 del; 2747 mod
Patch: https://git.openjdk.org/jdk/pull/17215.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17215/head:pull/17215
PR: https://git.openjdk.org/jdk/pull/17215
More information about the hotspot-compiler-dev
mailing list