RFR: 8322982: CTW fails to build after 8308753 [v3]

Paul Hohensee phh at openjdk.org
Wed Jan 10 17:32:25 UTC 2024


On Mon, 8 Jan 2024 20:08:37 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> This patch fixes the build error of CTW by sidelining ModuleInfoWriter.java. ModuleInfoWriter uses Class-File API, which has transitioned to preview.
>> If we really need to compile it, we have to append --enable-preview and --source N. 
>> 
>> The fact is CTW itself doesn't depend on ModuleInfoWriter. I think it's easier to maintain CTW if we filter it out in Makefile.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Wording and also remove add-modules required by ModuleInfoWriter.java

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17292#pullrequestreview-1813751239


More information about the hotspot-compiler-dev mailing list