RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test
Daniel Lundén
dlunden at openjdk.org
Tue Jan 16 09:56:21 UTC 2024
On Tue, 16 Jan 2024 08:54:10 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
> Thanks for working on this, Daniel!
>
> These tests would be more idiomatic, precise, and possibly even faster if the IR verification was applied to each vectorization method (`test_sum`, `test_addc`, etc.) separately, instead of doing it as a bulk check over the entire `TestIntVect::testInner()`. This can be achieved by using `applyIfCPUFeature` annotations in the IR checks, similarly to e.g. `test/hotspot/jtreg/compiler/loopopts/superword/RedTest_int.java`. I recognize this limitation is pre-existing, but this issue seems a good place to address it.
Thanks Roberto, it sounds reasonable to diverge from the original test and make it modular instead of sticking with the bulk test. I'll propose a new updated version. I'll also have a look at which jtreg `@requires` I can replace with IR framework annotations.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17428#issuecomment-1893407395
More information about the hotspot-compiler-dev
mailing list