RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Daniel Lundén
dlunden at openjdk.org
Wed Jan 17 10:05:51 UTC 2024
On Tue, 16 Jan 2024 08:54:10 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Refactor test to use multiple @Test
>
> Thanks for working on this, Daniel!
>
> These tests would be more idiomatic, precise, and possibly even faster if the IR verification was applied to each vectorization method (`test_sum`, `test_addc`, etc.) separately, instead of doing it as a bulk check over the entire `TestIntVect::testInner()`. This can be achieved by using `applyIfCPUFeature` annotations in the IR checks, similarly to e.g. `test/hotspot/jtreg/compiler/loopopts/superword/RedTest_int.java`. I recognize this limitation is pre-existing, but this issue seems a good place to address it.
I have now pushed a revised version (and updated the PR description). Please have a look when you have some spare time @robcasloz.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17428#issuecomment-1895476271
More information about the hotspot-compiler-dev
mailing list