RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]

Daniel Lundén dlunden at openjdk.org
Wed Jan 17 15:02:53 UTC 2024


On Wed, 17 Jan 2024 14:06:13 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor test to use multiple @Test
>
> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 510:
> 
>> 508:     }
>> 509: 
>> 510:     void test_divc(int[] a0, int[] a1) {
> 
> What about these tests without IR verification? Are they expected to be not vectorized?

That's a good question. I based the current `@IR` verifications on the vector nodes checked in the original test, and the `test_*` functions that do not currently have `@IR` annotations are those that do not result in any of the vector operations part of the original test.

I additionally checked a few of these functions in IGV, and none of them resulted in any vector operations. I guess we can remove them altogether, unless they are actually supposed to generate vector operations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1455790054


More information about the hotspot-compiler-dev mailing list