RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Christian Hagedorn
chagedorn at openjdk.org
Thu Jan 18 07:12:16 UTC 2024
On Wed, 17 Jan 2024 15:00:04 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 510:
>>
>>> 508: }
>>> 509:
>>> 510: void test_divc(int[] a0, int[] a1) {
>>
>> What about these tests without IR verification? Are they expected to be not vectorized?
>
> That's a good question. I based the current `@IR` verifications on the vector nodes checked in the original test, and the `test_*` functions that do not currently have `@IR` annotations are those that do not result in any of the vector operations part of the original test.
>
> I additionally checked a few of these functions in IGV, and none of them resulted in any vector operations. I guess we can remove them altogether, unless they are actually supposed to generate vector operations.
Thanks for checking it. Maybe @eme64 can also double check if these methods are expected to fail vectorization or if there are some missing optimization opportunities.
If the methods cannot be vectorized and we do not want to follow up on them, then I guess both is fine: leaving them in or removing them. Since it's an existing test it might be better though to keep the code as it previously was.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457017411
More information about the hotspot-compiler-dev
mailing list