RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Emanuel Peter
epeter at openjdk.org
Thu Jan 18 12:31:21 UTC 2024
On Thu, 18 Jan 2024 10:04:29 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:
>> Good point, I guess it's okay then to leave this code as as it is. It just looked odd to do correctness testing the way it does. But as you say, if you change that you probably also need to revisit other tests. That's probably not worth it. The main goal should be to introduce IR matching with the IR framework. So, I'm fine with not touching that code or the print statements.
>
> Would it perhaps be useful to create a separate RFE for your cleanup suggestions?
What I think might eventually be much more helpful, is to add result verification into the IR framework, and not have to hand-code it everywhere. That would be worth investing some time in, because it would simplify future testing, and make sure that people generally have to do result verification (it gets forgotten too easily).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457372919
More information about the hotspot-compiler-dev
mailing list