RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]

[Christian Hagedorn]

On Thu, 18 Jan 2024 12:28:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Would it perhaps be useful to create a separate RFE for your cleanup suggestions?
>
> What I think might eventually be much more helpful, is to add result verification into the IR framework, and not have to hand-code it everywhere. That would be worth investing some time in, because it would simplify future testing, and make sure that people generally have to do result verification (it gets forgotten too easily).

> Would it perhaps be useful to create a separate RFE for your cleanup suggestions?

Not sure if it's worth it. But generally, cleaning up tests is always a good thing.

> What I think might eventually be much more helpful, is to add result verification into the IR framework, and not have to hand-code it everywhere. That would be worth investing some time in, because it would simplify future testing, and make sure that people generally have to do result verification (it gets forgotten too easily).

That's a good point. We should provide some support for that at some point or even enforce it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457447107