RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Emanuel Peter
epeter at openjdk.org
Thu Jan 18 12:42:15 UTC 2024
On Thu, 18 Jan 2024 12:34:56 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/c2/cr7200264/TestIntVect.java line 50:
>>
>>> 48: public static void main(String[] args) {
>>> 49: TestFramework.runWithFlags("-XX:+IgnoreUnrecognizedVMOptions",
>>> 50: "-XX:StressLongCountedLoop=0");
>>
>> What is this for? Maybe add a comment.
>
> Yes, thanks. The previous comment that fell out is `// make sure int loops do not get converted to long`. I'll readd it.
And is that really necessary?
I don't see the flag in the IR Framework whitelist:
`test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java`
That would mean that if you do set the flag, then we would already disable the IR rules, but we could still run the tests, checking for correctness.
TLDR: I believe we should just be able to remove this flag completely.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457384364
More information about the hotspot-compiler-dev
mailing list