RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]

Daniel Lundén dlunden at openjdk.org
Thu Jan 18 13:09:14 UTC 2024


On Thu, 18 Jan 2024 12:39:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Yes, thanks. The previous comment that fell out is `// make sure int loops do not get converted to long`. I'll readd it.
>
> And is that really necessary?
> I don't see the flag in the IR Framework whitelist:
> `test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java`
> 
> That would mean that if you do set the flag, then we would already disable the IR rules, but we could still run the tests, checking for correctness.
> 
> TLDR: I believe we should just be able to remove this flag completely.

Isn't that whitelist only for flags passed down through JTREG? For example, when I add `"-XX:LoopUnrollLimit=0"` (not in the whitelist) to the `runWithFlags` arguments, all the IR tests fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457415142


More information about the hotspot-compiler-dev mailing list