RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Daniel Lundén
dlunden at openjdk.org
Thu Jan 18 15:52:15 UTC 2024
On Thu, 18 Jan 2024 14:51:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Yes, thanks, that corresponds to my understanding of the framework. Sorry if I was unclear, we of course do not want to include `-XX:LoopUnrollLimit=0`, that was just an example to illustrate the difference between whitelisting and `runWithFlags` (and what originally spawned this issue: https://bugs.openjdk.org/browse/JDK-8291809).
>>
>> The question is if we want to include `-XX:StressLongCountedLoop=0` in `runWithFlags`, as that flag was part of the original test. I'm fine with removing it if it no longer makes sense in the IR framework.
>
> Ok, great :)
>
> I assume that `-XX:StressLongCountedLoop=0` was there before, because if it was not, then one could make the test fail with JTREG, by for example passing `-XX:StressLongCountedLoop=1000`, right?
>
> But of course you would have to guard against all sorts of flags like this. For example `-Xint`. I just ran it with that flag, and it failed! :rofl:
>
> TLDR: this is an old mechanism, and a bad one. So please remove the flag ;)
OK, I'll remove it then!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17428#discussion_r1457644493
More information about the hotspot-compiler-dev
mailing list