RFR: JDK-8321984: IGV: Upgrade to Netbeans Platform 20 [v4]

[Roberto Castañeda Lozano]

On Thu, 18 Jan 2024 11:50:29 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> Upgraded IGV and dependencies to the newest Netbeans Platform 20 which was released on December 2023.
>> 
>> Tested that IGV still behaves as expected after the upgrade.
>
> Tobias Holenstein has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - make IGV build work with mainline JDK version
>  - remove requirement for nashorn

Thanks for addressing my earlier comment, Toby! Please update the copyright headers.

src/utils/IdealGraphVisualizer/pom.xml line 80:

> 78:                                 <rules>
> 79:                                     <requireJavaVersion>
> 80:                                       <version>17</version>

I suggest being a bit more conservative (safe) here and specifying an upper bound for the JDK version, since we cannot guarantee that all IGV dependencies will be compatible with any future JDK release. I suggest sticking to the newest JDK supported by the NetBeans Platform (for NetBeans 20 that would be JDK 21, see https://netbeans.apache.org/front/main/download/nb20/).

-------------

Changes requested by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17106#pullrequestreview-1831764474
PR Review Comment: https://git.openjdk.org/jdk/pull/17106#discussion_r1458498114