RFR: JDK-8321984: IGV: Upgrade to Netbeans Platform 20 [v4]
Tobias Holenstein
tholenstein at openjdk.org
Mon Jan 22 11:39:31 UTC 2024
On Fri, 19 Jan 2024 07:30:43 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Tobias Holenstein has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>>
>> - make IGV build work with mainline JDK version
>> - remove requirement for nashorn
>
> src/utils/IdealGraphVisualizer/pom.xml line 80:
>
>> 78: <rules>
>> 79: <requireJavaVersion>
>> 80: <version>17</version>
>
> I suggest being a bit more conservative (safe) here and specifying an upper bound for the JDK version, since we cannot guarantee that all IGV dependencies will be compatible with any future JDK release. I suggest sticking to the newest JDK supported by the NetBeans Platform (for NetBeans 20 that would be JDK 21, see https://netbeans.apache.org/front/main/download/nb20/).
ok, I changed it back to be JDK 17-21
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17106#discussion_r1461733837
More information about the hotspot-compiler-dev
mailing list