RFR: 8324213: C1: There is no need for Canonicalizer to handle IfOp

Dean Long dlong at openjdk.org
Fri Jan 19 21:41:32 UTC 2024


On Fri, 19 Jan 2024 15:24:12 GMT, Denghui Dong <ddong at openjdk.org> wrote:

> IfOp will not be created when building the graph, so there is no need for Canonicalizer to handle IfOp.

src/hotspot/share/c1/c1_Canonicalizer.cpp line 472:

> 470: 
> 471: void Canonicalizer::do_IfOp(IfOp* x) {
> 472: }

If you are saying this method can never be called, then shouldn't we make it report an error instead of being empty?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17499#discussion_r1459820958


More information about the hotspot-compiler-dev mailing list