RFR: 8282365: Consolidate and improve division by constant idealizations [v44]

[Quan Anh Mai]

On Tue, 23 Jan 2024 15:02:26 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> That is an excellent analysis. To add to the analysis, we do not really need the minimal value of `c`, since 2 values of `c` that both satisfy the inequations must give the same upper bits for all input values. As a result, for the purpose of the algorithm, they are equivalent.
>> 
>> My concern is that it will complicate the analysis, which is complicated enough, for a minor improvement in the exit conditions.
>
> I have no idea about the timing difference with the current exit condition or with the simplified one. It might indeed be negligible.
> Anyway, there's a choice now ;-)

@rgiulietti Thanks a lot for your patience in reviewing this patch. Do you have any more concerns or suggestions?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1465355389