RFR: 8282365: Consolidate and improve division by constant idealizations [v44]
Raffaello Giulietti
rgiulietti at openjdk.org
Wed Jan 24 18:15:56 UTC 2024
On Wed, 24 Jan 2024 18:06:18 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> I have no idea about the timing difference with the current exit condition or with the simplified one. It might indeed be negligible.
>> Anyway, there's a choice now ;-)
>
> @rgiulietti Thanks a lot for your patience in reviewing this patch. Do you have any more concerns or suggestions?
I've the impression that we can replace `m < c * d <= m + m / v` with the stricter `m < c * d < m + m / v` by using `N_neg - 1` instead of `N_neg`, but I need some time to have a solid proof.
That would simplify the code of the algorithm.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1465362000
More information about the hotspot-compiler-dev
mailing list