RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]
Daniel Lundén
dlunden at openjdk.org
Fri Jan 26 10:43:37 UTC 2024
On Fri, 26 Jan 2024 09:58:34 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> @eme64
>>
>>> @dlunde Given the findings here: [#17428 (comment)](https://github.com/openjdk/jdk/pull/17428#discussion_r1466460916) I think you should add a IR rule on every test.
>>
>> I don't quite understand, what IR rule do you want me to add for every test? I'll of course add what we discussed for the problematic `test_divc` and `test_divc_n`.
>>
>>> And for the ones that do not currently vectorize, please add a negative IR rule, so that we can detect when that changes. For example when we implement a feature, then we can properly fix up the IR rule.
>>
>> Sure, I'll add negative rules for tests that do not currently vectorize (at all).
>
>> Sure, I'll add negative rules for tests that do not currently vectorize (at all).
>
> Please, if you do this add a comment to each negative rule clarifying that it does not document the desired behavior of the system but the current behavior, to support future development and improvements.
@robcasloz @eme64 @chhagedorn: I've now added everything that we've discussed. Please have another look. I'll wait for approval before rerunning tests.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17428#issuecomment-1911836874
More information about the hotspot-compiler-dev
mailing list