RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test [v2]

Daniel Lundén dlunden at openjdk.org
Mon Jan 29 09:38:38 UTC 2024


On Thu, 25 Jan 2024 14:34:27 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Thanks @eme64. I've addressed all comments now; please have a look again.
>
> @dlunde Given the findings here: https://github.com/openjdk/jdk/pull/17428#discussion_r1466460916
> I think you should add a IR rule on every test.
> And for the ones that do not currently vectorize, please add a negative IR rule, so that we can detect when that changes.
> For example when we implement a feature, then we can properly fix up the IR rule.

Thanks @eme64, @robcasloz, and @chhagedorn. On aarch64, `test_divc` and `test_divc_n` do not vectorize. Therefore, I had to change to negative rules for that case. I suggest we investigate why it does not vectorize in a separate issue (if necessary).

Due to the above change, I'll wait for a final approval before integrating.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17428#issuecomment-1914304491


More information about the hotspot-compiler-dev mailing list