RFR: JDK-8322648: Improve class initialization barrier in TemplateTable::_new for PPC [v2]

Martin Doerr mdoerr at openjdk.org
Mon Jan 29 06:38:36 UTC 2024


On Mon, 29 Jan 2024 05:51:45 GMT, Varada M <varadam at openjdk.org> wrote:

>> ppc port implementation of https://github.com/openjdk/jdk/pull/17006
>> 
>> Fastdebug and Release : build and tier1 testing successful.
>> 
>> JBS Issue : [JDK-8322648](https://bugs.openjdk.org/browse/JDK-8322648)
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8322648: Improve class initialization barrier in TemplateTable::_new for PPC

src/hotspot/cpu/ppc/templateTable_ppc_64.cpp line 3808:

> 3806:     // Make sure klass is initialized.
> 3807:     assert(VM_Version::supports_fast_class_init_checks(), "Optimization requires support for fast class initialization checks");
> 3808:     __ clinit_barrier(Rcpool, R16_thread, nullptr /*L_fast_path*/, &Lslow_case);

`Rcpool` is the wrong parameter. You need to use `RinstanceKlass`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17518#discussion_r1469131963


More information about the hotspot-compiler-dev mailing list