RFR: 8324213: C1: There is no need for Canonicalizer to handle IfOp [v2]

[Christian Hagedorn]

On Fri, 19 Jan 2024 23:37:36 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> IfOp will not be created when building the graph, so there is no need for Canonicalizer to handle IfOp.
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

Marked as reviewed by chagedorn (Reviewer).

src/hotspot/share/c1/c1_Canonicalizer.cpp line 472:

> 470: 
> 471: void Canonicalizer::do_IfOp(IfOp* x) {
> 472:   ShouldNotReachHere();

Looks good, but maybe add a comment here why we cannot visit `IfOp` here (i.e. that `IfOp` is not created by the `GraphBuilder` but only later when eliminating conditional expressions with `CE_Eliminator`).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17499#pullrequestreview-1848163154
PR Review Comment: https://git.openjdk.org/jdk/pull/17499#discussion_r1469280880