RFR: 8324213: C1: There is no need for Canonicalizer to handle IfOp [v2]

Christian Hagedorn chagedorn at openjdk.org
Mon Jan 29 09:49:45 UTC 2024


On Mon, 29 Jan 2024 09:41:28 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> src/hotspot/share/c1/c1_Canonicalizer.cpp line 472:
>> 
>>> 470: 
>>> 471: void Canonicalizer::do_IfOp(IfOp* x) {
>>> 472:   ShouldNotReachHere();
>> 
>> Looks good, but maybe add a comment here why we cannot visit `IfOp` here (i.e. that `IfOp` is not created by the `GraphBuilder` but only later when eliminating conditional expressions with `CE_Eliminator`).
>
> Updated.

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17499#discussion_r1469323080


More information about the hotspot-compiler-dev mailing list